/pidgin/main: 77d8af8354e7: I think it's more appropriate to pus...

Mark Doliner mark at kingant.net
Tue Sep 11 20:32:07 EDT 2012

Changeset: 77d8af8354e7672756bb54db1cab8723be542e48
Author:	 Mark Doliner <mark at kingant.net>
Date:	 2012-09-11 17:32 -0700
Branch:	 default
URL: http://hg.pidgin.im/pidgin/main/rev/77d8af8354e7


I think it's more appropriate to push to the head of the queue rather than
the tail, here.  Because we're not adding a new request, we're re-adding
a request that we just popped but then realized that we can't handle right

I believe this matches the behavior from before the switch to GQueue in


 libpurple/dnsquery.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff --git a/libpurple/dnsquery.c b/libpurple/dnsquery.c
--- a/libpurple/dnsquery.c
+++ b/libpurple/dnsquery.c
@@ -608,7 +608,7 @@ handle_next_queued_request(void)
 		if (number_of_dns_children >= MAX_DNS_CHILDREN)
 			/* Apparently all our children are busy */
-			g_queue_push_tail(queued_requests, query_data);
+			g_queue_push_head(queued_requests, query_data);

More information about the Commits mailing list