/pidgin/main: bb0e3f84034c: Fix a regression: don't remove sent ...

Tomasz Wasilczyk tomkiewicz at cpw.pidgin.im
Wed Sep 19 07:14:44 EDT 2012


Changeset: bb0e3f84034c95da59b7fb5d71bc02a935ba63d1
Author:	 Tomasz Wasilczyk <tomkiewicz at cpw.pidgin.im>
Date:	 2012-09-19 13:14 +0200
Branch:	 default
URL: http://hg.pidgin.im/pidgin/main/rev/bb0e3f84034c

Description:

Fix a regression: don't remove sent images before passing them to prpl

diffstat:

 pidgin/gtkwebviewtoolbar.c |  4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diffs (14 lines):

diff --git a/pidgin/gtkwebviewtoolbar.c b/pidgin/gtkwebviewtoolbar.c
--- a/pidgin/gtkwebviewtoolbar.c
+++ b/pidgin/gtkwebviewtoolbar.c
@@ -594,7 +594,9 @@ do_insert_image_cb(GtkWidget *widget, in
 	g_free(filename);
 
 	gtk_webview_insert_image(GTK_WEBVIEW(toolbar->webview), id);
-	purple_imgstore_unref_by_id(id);
+	/* TODO: do it after passing an image to prpl, not before
+	 * purple_imgstore_unref_by_id(id);
+	 */
 }
 
 static void



More information about the Commits mailing list