/soc/2013/ankitkv/gobjectification: a9a28b8e0d85: prevent a cras...

Ankit Vani a at nevitus.org
Sat Aug 3 12:07:43 EDT 2013


Changeset: a9a28b8e0d856c7d17ce0bd84219f15f26bf9452
Author:	 Ankit Vani <a at nevitus.org>
Date:	 2013-08-03 20:41 +0530
Branch:	 soc.2013.gobjectification.plugins
URL: https://hg.pidgin.im/soc/2013/ankitkv/gobjectification/rev/a9a28b8e0d85

Description:

prevent a crash when no protocols are loaded

diffstat:

 pidgin/gtkaccount.c |  5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diffs (15 lines):

diff --git a/pidgin/gtkaccount.c b/pidgin/gtkaccount.c
--- a/pidgin/gtkaccount.c
+++ b/pidgin/gtkaccount.c
@@ -1736,6 +1736,11 @@ pidgin_account_dialog_show_continue(Purp
 			g_strdup(purple_account_get_protocol_id(dialog->account));
 	}
 
+	/* TODO if no protocols are loaded, this should inform the user that
+	        protocols need to be loaded instead of just doing nothing */
+	if (!dialog->prpl_info)
+		return;
+
 	dialog->prpl_info = purple_find_protocol_info(dialog->protocol_id);
 
 	dialog->window = win = pidgin_create_dialog((type == PIDGIN_ADD_ACCOUNT_DIALOG) ? _("Add Account") : _("Modify Account"),



More information about the Commits mailing list