/soc/2013/ashmew2/filetransferX: 7422ec1d438a: Finite Progress b...

Ashish Gupta ashmew2 at gmail.com
Mon Aug 5 09:36:09 EDT 2013


Changeset: 7422ec1d438a80123a999a0f7e1f4241bac82a7c
Author:	 Ashish Gupta <ashmew2 at gmail.com>
Date:	 2013-08-05 19:05 +0530
Branch:	 filetransferX
URL: https://hg.pidgin.im/soc/2013/ashmew2/filetransferX/rev/7422ec1d438a

Description:

Finite Progress but Crashes

diffstat:

 libpurple/protocols/jabber/google/google_session.c |  8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diffs (27 lines):

diff --git a/libpurple/protocols/jabber/google/google_session.c b/libpurple/protocols/jabber/google/google_session.c
--- a/libpurple/protocols/jabber/google/google_session.c
+++ b/libpurple/protocols/jabber/google/google_session.c
@@ -1035,6 +1035,9 @@ static void
 gtalk_xfer_start(PurpleXfer *xfer)
 {
 	purple_debug_info("google_session", "Inside gtalk_xfer_start()\n");
+
+/*TODO: Reading the whole file into memory as it's very experimental right now, Need to fix it for Bigger Files*/
+
 	if(purple_xfer_get_type(xfer) == PURPLE_XFER_SEND) {
 		guchar *buffer = g_malloc( xfer->bytes_remaining );
 		int size = fread( buffer, xfer->bytes_remaining, 1, xfer->dest_fp );
@@ -1054,9 +1057,12 @@ google_session_initiate_file_transfer(Ja
 {
 	PurpleXfer *xfer = purple_xfer_new(purple_connection_get_account(js->gc), PURPLE_XFER_SEND, session->remote_jid);
 	xfer->data = session;
-	purple_debug_info("google_session", "inside google_session_initiate_file_transfer\n");
+
 	purple_xfer_set_init_fnc( xfer, gtalk_xfer_init );
 	purple_xfer_set_start_fnc(xfer, gtalk_xfer_start);
+	purple_debug_info("google_session", "inside google_session_initiate_file_transfer.Requesting Xfer..\n");	
+	purple_xfer_request(xfer);
+	
 }
 
 static void



More information about the Commits mailing list