/soc/2013/ankitkv/gobjectification: 686376181100: don't touch 'e...

[Ankit Vani]

Changeset: 686376181100970ec2b697cfe9932938e6933761
Author:	 Ankit Vani <a at nevitus.org>
Date:	 2013-08-11 18:39 +0530
Branch:	 soc.2013.gobjectification.plugins
URL: https://hg.pidgin.im/soc/2013/ankitkv/gobjectification/rev/686376181100

Description:

don't touch 'error' member of PurplePluginInfoPrivate. it will only hold reason for a plugin not being loadable.

diffstat:

 libpurple/plugins.c |  10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)

diffs (21 lines):

diff --git a/libpurple/plugins.c b/libpurple/plugins.c
--- a/libpurple/plugins.c
+++ b/libpurple/plugins.c
@@ -91,15 +91,9 @@ purple_plugin_load(PurplePlugin *plugin)
 	}
 
 	if (!gplugin_plugin_manager_load_plugin(plugin, &error)) {
-		PurplePluginInfoPrivate *priv =
-				PURPLE_PLUGIN_INFO_GET_PRIVATE(purple_plugin_get_info(plugin));
-		g_free(priv->error);
-		priv->error = g_strdup(error->message);
+		purple_debug_error("plugins", "Failed to load plugin %s: %s",
+				purple_plugin_get_filename(plugin), error->message);
 		g_error_free(error);
-
-		purple_debug_error("plugins", "Failed to load plugin %s: %s",
-				purple_plugin_get_filename(plugin),
-				purple_plugin_get_error(plugin));
 		return FALSE;
 	}