/soc/2013/ankitkv/gobjectification: 6c8546db0982: Do not manuall...

Ankit Vani a at nevitus.org
Sun Aug 11 16:23:12 EDT 2013


Changeset: 6c8546db0982267d4f87eb68f5278ab121565e94
Author:	 Ankit Vani <a at nevitus.org>
Date:	 2013-08-12 01:12 +0530
Branch:	 soc.2013.gobjectification.plugins
URL: https://hg.pidgin.im/soc/2013/ankitkv/gobjectification/rev/6c8546db0982

Description:

Do not manually unregister command. This should be done in the core when a protocol is unloaded.

diffstat:

 libpurple/protocols/null/nullprpl.c |  5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diffs (31 lines):

diff --git a/libpurple/protocols/null/nullprpl.c b/libpurple/protocols/null/nullprpl.c
--- a/libpurple/protocols/null/nullprpl.c
+++ b/libpurple/protocols/null/nullprpl.c
@@ -67,10 +67,8 @@
 #include "util.h"
 #include "version.h"
 
-
 #define NULLPRPL_ID "prpl-null"
 static PurplePluginProtocolInfo *_null_protocol = NULL;
-static PurpleCmdId _msg_cmd;
 
 #define NULL_STATUS_ONLINE   "online"
 #define NULL_STATUS_AWAY     "away"
@@ -1181,7 +1179,7 @@ plugin_load(PurplePlugin *plugin, GError
   prpl_info.protocol_options = g_list_append(NULL, option);
 
   /* register whisper chat command, /msg */
-  _msg_cmd = purple_cmd_register("msg",
+  purple_cmd_register("msg",
                     "ws",                  /* args: recipient and message */
                     PURPLE_CMD_P_DEFAULT,  /* priority */
                     PURPLE_CMD_FLAG_CHAT,
@@ -1207,7 +1205,6 @@ plugin_unload(PurplePlugin *plugin, GErr
 {
   purple_debug_info("nullprpl", "shutting down\n");
 
-  purple_cmd_unregister(_msg_cmd);
   purple_protocols_remove(_null_protocol);
 
   return TRUE;



More information about the Commits mailing list