/pidgin/main: 79ebfc0d91df: Drop support for Netscape because it...

[Mark Doliner]

Changeset: 79ebfc0d91dfafcdda4dbe12a3b4686395869f6f
Author:	 Mark Doliner <mark at kingant.net>
Date:	 2013-12-06 01:14 -0800
Branch:	 default
URL: https://hg.pidgin.im/pidgin/main/rev/79ebfc0d91df

Description:

Drop support for Netscape because it's ancient, no longer exists, is
probably riddled with security holes, and anyone using it should be
publicly shamed.

diffstat:

 pidgin/gtknotify.c |  11 -----------
 pidgin/gtkprefs.c  |   8 +++++++-
 2 files changed, 7 insertions(+), 12 deletions(-)

diffs (46 lines):

diff --git a/pidgin/gtknotify.c b/pidgin/gtknotify.c
--- a/pidgin/gtknotify.c
+++ b/pidgin/gtknotify.c
@@ -1377,17 +1377,6 @@ pidgin_notify_uri(const char *uri)
 											 "openURL(%s,new-tab)",
 											 web_browser, args, escaped);
 	}
-	else if (!strcmp(web_browser, "netscape"))
-	{
-		command = g_strdup_printf("netscape %s", escaped);
-
-		if (place == PIDGIN_BROWSER_NEW_WINDOW)
-		{
-			remote_command = g_strdup_printf("netscape -remote "
-											 "openURL(%s,new-window)",
-											 escaped);
-		}
-	}
 	else if (!strcmp(web_browser, "opera"))
 	{
 		if (place == PIDGIN_BROWSER_NEW_WINDOW)
diff --git a/pidgin/gtkprefs.c b/pidgin/gtkprefs.c
--- a/pidgin/gtkprefs.c
+++ b/pidgin/gtkprefs.c
@@ -2302,7 +2302,6 @@ get_available_browsers(void)
 	static const struct browser possible_browsers[] = {
 		{N_("Seamonkey"), "seamonkey"},
 		{N_("Opera"), "opera"},
-		{N_("Netscape"), "netscape"},
 		{N_("Mozilla"), "mozilla"},
 		{N_("Konqueror"), "kfmclient"},
 		{N_("Google Chrome"), "google-chrome"},
@@ -4416,6 +4415,13 @@ pidgin_prefs_update_old(void)
 		purple_prefs_set_int(PIDGIN_PREFS_ROOT "/browsers/place",
 				PIDGIN_BROWSER_DEFAULT);
 	}
+
+	/* Added in 3.0.0. */
+	if (g_str_equal(
+			purple_prefs_get_string(PIDGIN_PREFS_ROOT "/browsers/browser"),
+			"netscape")) {
+		purple_prefs_set_string(PIDGIN_PREFS_ROOT "/browsers/browser", "xdg-open");
+	}
 #endif /* !_WIN32 */
 }