/pidgin/main: 0508b089c8ee: Add a missing break. I think maybe ...

Mark Doliner mark at kingant.net
Tue Feb 19 00:47:33 EST 2013


Changeset: 0508b089c8ee44cef47e6d9a3dd430c038ccbdb9
Author:	 Mark Doliner <mark at kingant.net>
Date:	 2013-02-18 21:37 -0800
Branch:	 release-2.x.y
URL: http://hg.pidgin.im/pidgin/main/rev/0508b089c8ee

Description:

Add a missing break.  I think maybe this was found by Coverity.
I'm not sure if this caused harm.  If it did, it would be something like:
1. You tried adding a buddy on oscar
2. It failed because you have too many items in your list
3. We sent an authorization request to the buddy

But maybe the auth request would have been ignored?  Auth requests
aren't used for AIM, and for ICQ you maybe would have already sent
an auth request, or you would need to send one in the future anyway,
so not a big deal.

diffstat:

 libpurple/protocols/oscar/oscar.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff --git a/libpurple/protocols/oscar/oscar.c b/libpurple/protocols/oscar/oscar.c
--- a/libpurple/protocols/oscar/oscar.c
+++ b/libpurple/protocols/oscar/oscar.c
@@ -4180,7 +4180,7 @@ static int purple_ssi_parseack(OscarData
 				if ((retval->name != NULL) && !purple_conv_present_error(retval->name, purple_connection_get_account(gc), buf))
 					purple_notify_error(gc, NULL, _("Unable to Add"), buf);
 				g_free(buf);
-			}
+			} break;
 
 			case 0x000e: { /* buddy requires authorization */
 				if ((retval->action == SNAC_SUBTYPE_FEEDBAG_ADD) && (retval->name))



More information about the Commits mailing list