/pidgin/main: 83e5594ced88: Fix a few bogus NULL checks

Daniel Atallah datallah at pidgin.im
Sun Feb 24 22:48:17 EST 2013


Changeset: 83e5594ced889c57cd73a66faccafd35d103ce67
Author:	 Daniel Atallah <datallah at pidgin.im>
Date:	 2013-02-24 22:46 -0500
Branch:	 release-2.x.y
URL: https://hg.pidgin.im/pidgin/main/rev/83e5594ced88

Description:

Fix a few bogus NULL checks

diffstat:

 libpurple/buddyicon.c                        |  2 +-
 libpurple/protocols/jabber/auth_digest_md5.c |  4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diffs (26 lines):

diff --git a/libpurple/buddyicon.c b/libpurple/buddyicon.c
--- a/libpurple/buddyicon.c
+++ b/libpurple/buddyicon.c
@@ -455,7 +455,7 @@ purple_buddy_icon_update(PurpleBuddyIcon
 		purple_conv_im_set_icon(PURPLE_CONV_IM(conv), icon_to_set);
 
 	/* icon's refcount was incremented above */
-	if (icon) purple_buddy_icon_unref(icon);
+	purple_buddy_icon_unref(icon);
 }
 
 void
diff --git a/libpurple/protocols/jabber/auth_digest_md5.c b/libpurple/protocols/jabber/auth_digest_md5.c
--- a/libpurple/protocols/jabber/auth_digest_md5.c
+++ b/libpurple/protocols/jabber/auth_digest_md5.c
@@ -184,8 +184,8 @@ digest_md5_handle_challenge(JabberStream
 	dec_in = (char *)purple_base64_decode(enc_in, NULL);
 	purple_debug_misc("jabber", "decoded challenge (%"
 			G_GSIZE_FORMAT "): %s\n",
-			dec_in != NULL ? strlen(dec_in) : 0,
-			dec_in != NULL  ? dec_in : "(null)");
+			strlen(dec_in),
+			dec_in);
 
 	parts = jabber_auth_digest_md5_parse(dec_in);
 



More information about the Commits mailing list