/pidgin/main: 1e1973bdfe32: MXit: Maximum length of contact's al...

Andrew Victor andrew.victor at mxit.com
Wed Jan 16 09:34:42 EST 2013


Changeset: 1e1973bdfe328d6b0c63fdff5e01bc9fe2292948
Author:	 Andrew Victor <andrew.victor at mxit.com>
Date:	 2013-01-16 15:17 +0200
Branch:	 release-2.x.y
URL: http://hg.pidgin.im/pidgin/main/rev/1e1973bdfe32

Description:

MXit: Maximum length of contact's alias and group were incorrectly defined, possibly leading to truncation.

diffstat:

 libpurple/protocols/mxit/roster.h |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (23 lines):

diff --git a/libpurple/protocols/mxit/roster.h b/libpurple/protocols/mxit/roster.h
--- a/libpurple/protocols/mxit/roster.h
+++ b/libpurple/protocols/mxit/roster.h
@@ -97,7 +97,7 @@
 /* client protocol constants */
 #define		MXIT_CP_MAX_JID_LEN			64
 #define		MXIT_CP_MAX_GROUP_LEN		32
-#define		MXIT_CP_MAX_ALIAS_LEN		48
+#define		MXIT_CP_MAX_ALIAS_LEN		100
 
 #define		MXIT_DEFAULT_GROUP			"MXit"
 
@@ -107,8 +107,8 @@
  */
 struct contact {
 	char		username[MXIT_CP_MAX_JID_LEN+1];	/* unique contact name (with domain) */
-	char		alias[MXIT_CP_MAX_GROUP_LEN+1];		/* contact alias (what will be seen) */
-	char		groupname[MXIT_CP_MAX_ALIAS_LEN+1];	/* contact group name */
+	char		alias[MXIT_CP_MAX_ALIAS_LEN+1];		/* contact alias (what will be seen) */
+	char		groupname[MXIT_CP_MAX_GROUP_LEN+1];	/* contact group name */
 
 	short		type;								/* contact type */
 	short		mood;								/* contact current mood */



More information about the Commits mailing list