/soc/2013/ankitkv/gobjectification: eb42f0726a08: Removed unnece...

Ankit Vani a at nevitus.org
Sat Jul 13 12:17:00 EDT 2013


Changeset: eb42f0726a084610d81cdb385d00263b4852245e
Author:	 Ankit Vani <a at nevitus.org>
Date:	 2013-07-13 21:46 +0530
Branch:	 soc.2013.gobjectification
URL: https://hg.pidgin.im/soc/2013/ankitkv/gobjectification/rev/eb42f0726a08

Description:

Removed unnecessary use of connection's disconnect_timeout member from jabber's parser.c

diffstat:

 libpurple/connection.c              |  3 +--
 libpurple/protocols/jabber/parser.c |  4 ----
 2 files changed, 1 insertions(+), 6 deletions(-)

diffs (27 lines):

diff --git a/libpurple/connection.c b/libpurple/connection.c
--- a/libpurple/connection.c
+++ b/libpurple/connection.c
@@ -79,8 +79,7 @@ struct _PurpleConnectionPrivate
 	 */
 	gboolean wants_to_die;
 
-	guint disconnect_timeout;  /**< Timer used for nasty stack tricks
-	                                TODO Get rid of this.                     */
+	guint disconnect_timeout;  /**< Timer used for nasty stack tricks         */
 	time_t last_received;      /**< When we last received a packet. Set by the
 	                                prpl to avoid sending unneeded keepalives */
 };
diff --git a/libpurple/protocols/jabber/parser.c b/libpurple/protocols/jabber/parser.c
--- a/libpurple/protocols/jabber/parser.c
+++ b/libpurple/protocols/jabber/parser.c
@@ -308,10 +308,6 @@ void jabber_parser_process(JabberStream 
 	}
 
 	if (js->protocol_version.major == 0 && js->protocol_version.minor == 9 &&
-#warning Is this (gc->disconnect_timeout) required here? If so, an alternative is needed.
-#if 0
-			!js->gc->disconnect_timeout &&
-#endif
 			(js->state == JABBER_STREAM_INITIALIZING ||
 			 js->state == JABBER_STREAM_INITIALIZING_ENCRYPTION)) {
 		/*



More information about the Commits mailing list