/soc/2013/ankitkv/gobjectification: e4e9c7530211: Added warnings...

Ankit Vani a at nevitus.org
Mon Jul 15 10:15:42 EDT 2013


Changeset: e4e9c7530211a9d9b29d5c2f7890e76222425379
Author:	 Ankit Vani <a at nevitus.org>
Date:	 2013-07-15 19:42 +0530
Branch:	 soc.2013.gobjectification
URL: https://hg.pidgin.im/soc/2013/ankitkv/gobjectification/rev/e4e9c7530211

Description:

Added warnings to change GValue calls to _object when PurpleBuddyIcon is a GObject

diffstat:

 libpurple/blistnodetypes.c    |  3 +++
 libpurple/conversationtypes.c |  3 +++
 2 files changed, 6 insertions(+), 0 deletions(-)

diffs (54 lines):

diff --git a/libpurple/blistnodetypes.c b/libpurple/blistnodetypes.c
--- a/libpurple/blistnodetypes.c
+++ b/libpurple/blistnodetypes.c
@@ -549,6 +549,7 @@ purple_buddy_set_property(GObject *obj, 
 			purple_buddy_set_server_alias(buddy, g_value_get_string(value));
 			break;
 		case BUDDY_PROP_ICON:
+#warning TODO: change get_boxed to get_object when PurpleBuddyIcon is a GObject
 			purple_buddy_set_icon(buddy, g_value_get_boxed(value));
 			break;
 		case BUDDY_PROP_ACCOUNT:
@@ -581,6 +582,7 @@ purple_buddy_get_property(GObject *obj, 
 			g_value_set_string(value, purple_buddy_get_server_alias(buddy));
 			break;
 		case BUDDY_PROP_ICON:
+#warning TODO: change set_static_boxed to set_object when PurpleBuddyIcon is a GObject
 			g_value_set_static_boxed(value, purple_buddy_get_icon(buddy));
 			break;
 		case BUDDY_PROP_ACCOUNT:
@@ -698,6 +700,7 @@ static void purple_buddy_class_init(Purp
 				G_PARAM_READWRITE)
 			);
 
+#warning TODO: change spec_boxed to spec_object when PurpleBuddyIcon is a GObject
 	g_object_class_install_property(obj_class, BUDDY_PROP_ICON,
 			g_param_spec_boxed(BUDDY_PROP_ICON_S, _("Buddy icon"),
 				_("The icon for the buddy."), PURPLE_TYPE_BUDDY_ICON,
diff --git a/libpurple/conversationtypes.c b/libpurple/conversationtypes.c
--- a/libpurple/conversationtypes.c
+++ b/libpurple/conversationtypes.c
@@ -390,6 +390,7 @@ purple_im_conversation_set_property(GObj
 		case IM_PROP_TYPING_STATE:
 			purple_im_conversation_set_typing_state(im, g_value_get_enum(value));
 			break;
+#warning TODO: change get_boxed to get_object when PurpleBuddyIcon is a GObject
 		case IM_PROP_ICON:
 			purple_im_conversation_set_icon(im, g_value_get_boxed(value));
 			break;
@@ -410,6 +411,7 @@ purple_im_conversation_get_property(GObj
 		case IM_PROP_TYPING_STATE:
 			g_value_set_enum(value, purple_im_conversation_get_typing_state(im));
 			break;
+#warning TODO: change set_static_boxed to set_object when PurpleBuddyIcon is a GObject
 		case IM_PROP_ICON:
 			g_value_set_static_boxed(value, purple_im_conversation_get_icon(im));
 			break;
@@ -513,6 +515,7 @@ static void purple_im_conversation_class
 				G_PARAM_READWRITE)
 			);
 
+#warning TODO: change spec_boxed to spec_object when PurpleBuddyIcon is a GObject
 	g_object_class_install_property(obj_class, IM_PROP_ICON,
 			g_param_spec_boxed(IM_PROP_ICON_S, _("Buddy icon"),
 				_("The buddy icon for the IM."), PURPLE_TYPE_BUDDY_ICON,



More information about the Commits mailing list