/soc/2013/ankitkv/gobjectification: 979a2d8fb770: Made purple_no...
Ankit Vani
a at nevitus.org
Tue Jul 16 11:37:19 EDT 2013
Changeset: 979a2d8fb770fef0821fe39819f50cecaef86302
Author: Ankit Vani <a at nevitus.org>
Date: 2013-07-16 21:07 +0530
Branch: soc.2013.gobjectification
URL: https://hg.pidgin.im/soc/2013/ankitkv/gobjectification/rev/979a2d8fb770
Description:
Made purple_notify_user_info_entry_destroy() public, so entries can be free'd after calling remove_entry
diffstat:
libpurple/notify.c | 2 +-
libpurple/notify.h | 14 +++++++-------
2 files changed, 8 insertions(+), 8 deletions(-)
diffs (51 lines):
diff --git a/libpurple/notify.c b/libpurple/notify.c
--- a/libpurple/notify.c
+++ b/libpurple/notify.c
@@ -453,7 +453,7 @@ purple_notify_user_info_entry_new(const
return user_info_entry;
}
-static void
+void
purple_notify_user_info_entry_destroy(PurpleNotifyUserInfoEntry *user_info_entry)
{
g_return_if_fail(user_info_entry != NULL);
diff --git a/libpurple/notify.h b/libpurple/notify.h
--- a/libpurple/notify.h
+++ b/libpurple/notify.h
@@ -509,21 +509,14 @@ void purple_notify_user_info_prepend_pai
*/
void purple_notify_user_info_prepend_pair_plaintext(PurpleNotifyUserInfo *user_info, const char *label, const char *value);
-#if !(defined PURPLE_DISABLE_DEPRECATED) || (defined _PURPLE_NOTIFY_C_)
/**
* Remove a PurpleNotifyUserInfoEntry from a PurpleNotifyUserInfo object
* without freeing the entry.
*
* @param user_info The PurpleNotifyUserInfo
* @param user_info_entry The PurpleNotifyUserInfoEntry
- *
- * @deprecated Nothing is using this function and it should be removed
- * in 3.0.0. Or, if we decide we want to keep it in 3.0.0
- * then we should make purple_notify_user_info_entry_destroy
- * public so that entries can be free'd after they're removed.
*/
void purple_notify_user_info_remove_entry(PurpleNotifyUserInfo *user_info, PurpleNotifyUserInfoEntry *user_info_entry);
-#endif
/**
* Create a new PurpleNotifyUserInfoEntry
@@ -549,6 +542,13 @@ void purple_notify_user_info_remove_entr
PurpleNotifyUserInfoEntry *purple_notify_user_info_entry_new(const char *label, const char *value);
/**
+ * Destroy a PurpleNotifyUserInfoEntry
+ *
+ * @param user_info_entry The PurpleNotifyUserInfoEntry
+ */
+void purple_notify_user_info_entry_destroy(PurpleNotifyUserInfoEntry *user_info_entry);
+
+/**
* Add a section break. A UI might display this as a horizontal line.
*
* @param user_info The PurpleNotifyUserInfo
More information about the Commits
mailing list