/soc/2013/ankitkv/gobjectification: 7fdf8dca3bc1: Changed types ...

Ankit Vani a at nevitus.org
Wed Jul 17 16:22:19 EDT 2013


Changeset: 7fdf8dca3bc17b55fae37ce2d24bc9a08a1558eb
Author:	 Ankit Vani <a at nevitus.org>
Date:	 2013-07-18 01:52 +0530
Branch:	 soc.2013.gobjectification
URL: https://hg.pidgin.im/soc/2013/ankitkv/gobjectification/rev/7fdf8dca3bc1

Description:

Changed types for 'outgoing' values to G_TYPE_POINTER in signal registrations in protocols

diffstat:

 libpurple/protocols/irc/irc.c       |  6 ++++--
 libpurple/protocols/jabber/jabber.c |  9 ++++++---
 2 files changed, 10 insertions(+), 5 deletions(-)

diffs (47 lines):

diff --git a/libpurple/protocols/irc/irc.c b/libpurple/protocols/irc/irc.c
--- a/libpurple/protocols/irc/irc.c
+++ b/libpurple/protocols/irc/irc.c
@@ -995,10 +995,12 @@ static gboolean load_plugin (PurplePlugi
 
 	purple_signal_register(plugin, "irc-sending-text",
 			     purple_marshal_VOID__POINTER_POINTER, G_TYPE_NONE, 2,
-			     PURPLE_TYPE_CONNECTION, G_TYPE_STRING);
+			     PURPLE_TYPE_CONNECTION,
+			     G_TYPE_POINTER); /* pointer to a string */
 	purple_signal_register(plugin, "irc-receiving-text",
 			     purple_marshal_VOID__POINTER_POINTER, G_TYPE_NONE, 2,
-			     PURPLE_TYPE_CONNECTION, G_TYPE_STRING);
+			     PURPLE_TYPE_CONNECTION,
+			     G_TYPE_POINTER); /* pointer to a string */
 	return TRUE;
 }
 
diff --git a/libpurple/protocols/jabber/jabber.c b/libpurple/protocols/jabber/jabber.c
--- a/libpurple/protocols/jabber/jabber.c
+++ b/libpurple/protocols/jabber/jabber.c
@@ -3991,11 +3991,13 @@ void jabber_plugin_init(PurplePlugin *pl
 
 	purple_signal_register(plugin, "jabber-receiving-xmlnode",
 			purple_marshal_VOID__POINTER_POINTER, G_TYPE_NONE, 2,
-			PURPLE_TYPE_CONNECTION, PURPLE_TYPE_XMLNODE);
+			PURPLE_TYPE_CONNECTION,
+			G_TYPE_POINTER); /* modifiable xmlnode */
 
 	purple_signal_register(plugin, "jabber-sending-xmlnode",
 			purple_marshal_VOID__POINTER_POINTER, G_TYPE_NONE, 2,
-			PURPLE_TYPE_CONNECTION, PURPLE_TYPE_XMLNODE);
+			PURPLE_TYPE_CONNECTION,
+			G_TYPE_POINTER); /* modifiable xmlnode */
 
 	/*
 	 * Do not remove this or the plugin will fail. Completely. You have been
@@ -4007,7 +4009,8 @@ void jabber_plugin_init(PurplePlugin *pl
 
 	purple_signal_register(plugin, "jabber-sending-text",
 			     purple_marshal_VOID__POINTER_POINTER, G_TYPE_NONE, 2,
-			     PURPLE_TYPE_CONNECTION, G_TYPE_STRING);
+			     PURPLE_TYPE_CONNECTION,
+			     G_TYPE_POINTER); /* pointer to a string */
 
 	purple_signal_register(plugin, "jabber-receiving-message",
 			purple_marshal_BOOLEAN__POINTER_POINTER_POINTER_POINTER_POINTER_POINTER,



More information about the Commits mailing list