/soc/2013/ankitkv/gobjectification: 255148c286ab: Added some Pur...

[Ankit Vani]

Changeset: 255148c286ab4468a48251890b9a6f40b624af98
Author:	 Ankit Vani <a at nevitus.org>
Date:	 2013-06-22 22:41 +0530
Branch:	 soc.2013.gobjectification
URL: https://hg.pidgin.im/soc/2013/ankitkv/gobjectification/rev/255148c286ab

Description:

Added some PurpleConversation virtual class methods.
* purple_conversation_write()
* purple_conversation_send()
* purple_conversation_send_with_flags()

diffstat:

 libpurple/conversation.h      |  28 ++++++++++++++++++++++++++--
 libpurple/conversationtypes.h |  32 ++++++++++++++++----------------
 2 files changed, 42 insertions(+), 18 deletions(-)

diffs (144 lines):

diff --git a/libpurple/conversation.h b/libpurple/conversation.h
--- a/libpurple/conversation.h
+++ b/libpurple/conversation.h
@@ -131,6 +131,30 @@ struct _PurpleConversationClass {
 	/*< private >*/
 	GObjectClass parent_class;
 
+	/** @copydoc purple_conversation_write() TODO */
+	void (*write)(PurpleConversation *conv, const char *who,
+			const char *message, PurpleConversationMessageFlags flags,
+			time_t mtime);
+
+	/** TODO pure virtual
+	 * Sends a message to this conversation.
+	 *
+	 * @param conv    The conversation.
+	 * @param message The message to send.
+	 */
+	void (*send)(PurpleConversation *conv, const char *message);
+
+	/** TODO pure virtual
+	 * Sends a message to this conversation with specified flags.
+	 *
+	 * @param conv    The conversation.
+	 * @param message The message to send.
+	 * @param flags   The PurpleConversationMessageFlags flags to use in addition to
+	 *                PURPLE_CONVERSATION_MESSAGE_SEND.
+	 */
+	void (*send_with_flags)(PurpleConversation *conv,
+			const char *message, PurpleConversationMessageFlags flags);
+
 	void (*_purple_reserved1)(void);
 	void (*_purple_reserved2)(void);
 	void (*_purple_reserved3)(void);
@@ -416,7 +440,7 @@ void purple_conversation_set_data(Purple
  */
 gpointer purple_conversation_get_data(PurpleConversation *conv, const char *key);
 
-/**
+/** TODO virtual and chainback
  * Writes to a conversation window.
  *
  * This function should not be used to write IM or chat messages. Use
@@ -433,7 +457,7 @@ gpointer purple_conversation_get_data(Pu
  * @param flags   The message flags.
  * @param mtime   The time the message was sent.
  *
- * @see purple_im_conversation_write()
+ * @see purple_im_conversation_write() TODO rectify this
  * @see purple_chat_conversation_write()
  */
 void purple_conversation_write(PurpleConversation *conv, const char *who,
diff --git a/libpurple/conversationtypes.h b/libpurple/conversationtypes.h
--- a/libpurple/conversationtypes.h
+++ b/libpurple/conversationtypes.h
@@ -336,7 +336,7 @@ guint purple_im_conversation_get_send_ty
  */
 void purple_im_conversation_update_typing(PurpleIMConversation *im);
 
-/**
+/** TODO override
  * Writes to an IM.
  *
  * @param im      The IM.
@@ -345,19 +345,19 @@ void purple_im_conversation_update_typin
  * @param flags   The message flags.
  * @param mtime   The time the message was sent.
  */
-void purple_im_conversation_write(PurpleIMConversation *im, const char *who,
+/*void purple_im_conversation_write(PurpleIMConversation *im, const char *who,
 						const char *message, PurpleConversationMessageFlags flags,
-						time_t mtime);
+						time_t mtime);*/
 
-/**
+/** TODO override
  * Sends a message to this IM conversation.
  *
  * @param im      The IM.
  * @param message The message to send.
  */
-void purple_im_conversation_send(PurpleIMConversation *im, const char *message);
+/*void purple_im_conversation_send(PurpleIMConversation *im, const char *message);*/
 
-/**
+/** TODO override
  * Sends a message to this IM conversation with specified flags.
  *
  * @param im      The IM.
@@ -365,8 +365,8 @@ void purple_im_conversation_send(PurpleI
  * @param flags   The PurpleConversationMessageFlags flags to use in addition to
  *                PURPLE_CONVERSATION_MESSAGE_SEND.
  */
-void purple_im_conversation_send_with_flags(PurpleIMConversation *im,
-		const char *message, PurpleConversationMessageFlags flags);
+/*void purple_im_conversation_send_with_flags(PurpleIMConversation *im,
+		const char *message, PurpleConversationMessageFlags flags);*/
 
 /*@}*/
 
@@ -501,7 +501,7 @@ void purple_chat_conversation_set_id(Pur
  */
 int purple_chat_conversation_get_id(const PurpleChatConversation *chat);
 
-/**
+/** TODO override
  * Writes to a chat.
  *
  * @param chat    The chat.
@@ -510,27 +510,27 @@ int purple_chat_conversation_get_id(cons
  * @param flags   The flags.
  * @param mtime   The time the message was sent.
  */
-void purple_chat_conversation_write(PurpleChatConversation *chat, const char *who,
+/*void purple_chat_conversation_write(PurpleChatConversation *chat, const char *who,
 						  const char *message, PurpleConversationMessageFlags flags,
-						  time_t mtime);
+						  time_t mtime);*/
 
-/**
+/** TODO override
  * Sends a message to this chat conversation.
  *
  * @param chat    The chat.
  * @param message The message to send.
  */
-void purple_chat_conversation_send(PurpleChatConversation *chat, const char *message);
+/*void purple_chat_conversation_send(PurpleChatConversation *chat, const char *message);*/
 
-/**
+/** TODO override
  * Sends a message to this chat conversation with specified flags.
  *
  * @param chat    The chat.
  * @param message The message to send.
  * @param flags   The PurpleConversationMessageFlags flags to use.
  */
-void purple_chat_conversation_send_with_flags(PurpleChatConversation *chat,
-		const char *message, PurpleConversationMessageFlags flags);
+/*void purple_chat_conversation_send_with_flags(PurpleChatConversation *chat,
+		const char *message, PurpleConversationMessageFlags flags);*/
 
 /**
  * Adds a user to a chat.