/soc/2013/ankitkv/gobjectification: 2571aa9077eb: Removed false ...

[Ankit Vani]

Changeset: 2571aa9077eb9dbe7ee9bf6c78cef52b10855aea
Author:	 Ankit Vani <a at nevitus.org>
Date:	 2013-06-24 00:57 +0530
Branch:	 soc.2013.gobjectification
URL: https://hg.pidgin.im/soc/2013/ankitkv/gobjectification/rev/2571aa9077eb

Description:

Removed false alarms of memory leak

diffstat:

 libpurple/protocols/msn/msg.c         |  1 -
 libpurple/protocols/msn/switchboard.c |  2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)

diffs (23 lines):

diff --git a/libpurple/protocols/msn/msg.c b/libpurple/protocols/msn/msg.c
--- a/libpurple/protocols/msn/msg.c
+++ b/libpurple/protocols/msn/msg.c
@@ -997,7 +997,6 @@ void msn_emoticon_msg(MsnCmdProc *cmdpro
 		 * the conversation doesn't exist then we cannot associate the new
 		 * smiley with its GtkIMHtml widget. */
 		if (!conv) {
-			/* TODO memory leak - dispose this conv */
 			conv = PURPLE_CONVERSATION(purple_im_conversation_new(session->account, who));
 		}
 
diff --git a/libpurple/protocols/msn/switchboard.c b/libpurple/protocols/msn/switchboard.c
--- a/libpurple/protocols/msn/switchboard.c
+++ b/libpurple/protocols/msn/switchboard.c
@@ -302,7 +302,7 @@ msn_switchboard_add_user(MsnSwitchBoard 
 		{
 			GList *l;
 
-#if 0 /* TODO if conv exists, it gets leaked? */
+#if 0
 			/* this is bad - it causes msn_switchboard_close to be called on the
 			 * switchboard we're in the middle of using :( */
 			if (swboard->conv != NULL)