/pidgin/main: c2cb04f2632a: Increase size of static buffer in gt...

Mark Doliner mark at kingant.net
Sun Mar 3 22:59:22 EST 2013

Changeset: c2cb04f2632a86d1092d678eb513417f595f7054
Author:	 Mark Doliner <mark at kingant.net>
Date:	 2013-03-03 19:58 -0800
Branch:	 release-2.x.y
URL: https://hg.pidgin.im/pidgin/main/rev/c2cb04f2632a


Increase size of static buffer in gtkimhtml from 1KiB to 16KiB.

1 KiB isn't enough for long URLs and we would attempt to send
malformed HTML in that case because the return value would not
include the closing ">

This might address one of the problems this guy mentioned:
It's hard to know for sure... I couldn't test receiving long
URLs until I made this change, and now that I've made it I'm
able to receive URLs with no problems.


 pidgin/gtkimhtml.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff --git a/pidgin/gtkimhtml.c b/pidgin/gtkimhtml.c
--- a/pidgin/gtkimhtml.c
+++ b/pidgin/gtkimhtml.c
@@ -5094,7 +5094,7 @@ void gtk_imhtml_insert_image_at_iter(Gtk
 static const gchar *tag_to_html_start(GtkTextTag *tag)
 	const gchar *name;
-	static gchar buf[1024];
+	static gchar buf[16384];
 	name = tag->name;
 	g_return_val_if_fail(name != NULL, "");

More information about the Commits mailing list