/pidgin/main: 77908f5d8996: Gadu-Gadu: fix use-after-free in dns...

Tomasz Wasilczyk tomkiewicz at cpw.pidgin.im
Wed Mar 20 17:34:43 EDT 2013


Changeset: 77908f5d899685e8167de020249bf96acdcedac6
Author:	 Tomasz Wasilczyk <tomkiewicz at cpw.pidgin.im>
Date:	 2013-03-20 22:34 +0100
Branch:	 default
URL: https://hg.pidgin.im/pidgin/main/rev/77908f5d8996

Description:

Gadu-Gadu: fix use-after-free in dns code

diffstat:

 libpurple/protocols/gg/resolver-purple.c |  4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diffs (21 lines):

diff --git a/libpurple/protocols/gg/resolver-purple.c b/libpurple/protocols/gg/resolver-purple.c
--- a/libpurple/protocols/gg/resolver-purple.c
+++ b/libpurple/protocols/gg/resolver-purple.c
@@ -75,6 +75,8 @@ void ggp_resolver_purple_cb(GSList *host
 	purple_debug_misc("gg", "ggp_resolver_purple_cb(%p, %p, \"%s\")\n",
 		hosts, cbdata, error_message);
 	
+	data->purpleQuery = NULL;
+	
 	if (error_message)
 	{
 		purple_debug_error("gg", "ggp_resolver_purple_cb failed: %s\n",
@@ -183,6 +185,8 @@ void ggp_resolver_purple_cleanup(void **
 		return;
 	*private_data = NULL;
 	
+	if (data->purpleQuery)
+		purple_dnsquery_destroy(data->purpleQuery);
 	if (data->pipes[0])
 		close(data->pipes[0]);
 	if (data->pipes[1])



More information about the Commits mailing list