/soc/2013/ankitkv/gobjectification: e02979f51a08: Removed buddy-...

Ankit Vani a at nevitus.org
Mon Oct 21 17:22:59 EDT 2013


Changeset: e02979f51a08c2f3cb159f49200e08971bb11886
Author:	 Ankit Vani <a at nevitus.org>
Date:	 2013-10-22 02:07 +0530
Branch:	 soc.2013.gobjectification
URL: https://hg.pidgin.im/soc/2013/ankitkv/gobjectification/rev/e02979f51a08

Description:

Removed buddy-added and buddy-removed signals

diffstat:

 ChangeLog.API         |   1 +
 doc/blist-signals.dox |  20 --------------------
 libpurple/buddylist.c |  12 ------------
 3 files changed, 1 insertions(+), 32 deletions(-)

diffs (84 lines):

diff --git a/ChangeLog.API b/ChangeLog.API
--- a/ChangeLog.API
+++ b/ChangeLog.API
@@ -265,6 +265,7 @@ version 3.0.0 (??/??/????):
 		* xmlnode_* functions are now purple_xmlnode_*
 
 		Removed:
+		* buddy-added and buddy-removed blist signals
 		* privacy.h file
 		* value.h file
 		* _PurpleCipherBatchMode
diff --git a/doc/blist-signals.dox b/doc/blist-signals.dox
--- a/doc/blist-signals.dox
+++ b/doc/blist-signals.dox
@@ -7,8 +7,6 @@
   @signal buddy-signed-off
   @signal update-idle
   @signal blist-node-extended-menu
-  @signal buddy-added
-  @signal buddy-removed
   @signal buddy-icon-changed
   @signal blist-node-aliased
   @signal buddy-caps-changed
@@ -92,24 +90,6 @@ void (*blist_node_removed)(PurpleBlistNo
    Emitted when a blist node is removed from the buddy list.
  @endsignaldef
 
- @signaldef buddy-added
-  @signalproto
-void (*buddy_added)(PurpleBuddy *buddy)
-  @endsignalproto
-  @signaldesc
-   Emitted when a new buddy is added to the buddy list.
-  @deprecated Use blist-node-added instead.
- @endsignaldef
-
- @signaldef buddy-removed
-  @signalproto
-void (*buddy_removed)(PurpleBuddy *buddy)
-  @endsignalproto
-  @signaldesc
-   Emitted when a buddy is removed from the buddy list.
-  @deprecated Use blist-node-removed instead.
- @endsignaldef
-
  @signaldef buddy-icon-changed
   @signalproto
 void (*buddy_icon_changed)(PurpleBuddy *buddy)
diff --git a/libpurple/buddylist.c b/libpurple/buddylist.c
--- a/libpurple/buddylist.c
+++ b/libpurple/buddylist.c
@@ -1054,8 +1054,6 @@ void purple_blist_add_buddy(PurpleBuddy 
 	}
 
 	/* Signal that the buddy has been added */
-	purple_signal_emit(purple_blist_get_handle(), "buddy-added", buddy);
-
 	purple_signal_emit(purple_blist_get_handle(), "blist-node-added",
 			PURPLE_BLIST_NODE(buddy));
 }
@@ -1406,8 +1404,6 @@ void purple_blist_remove_buddy(PurpleBud
 	purple_pounce_destroy_all_by_buddy(buddy);
 
 	/* Signal that the buddy has been removed before freeing the memory for it */
-	purple_signal_emit(purple_blist_get_handle(), "buddy-removed", buddy);
-
 	purple_signal_emit(purple_blist_get_handle(), "blist-node-removed",
 			PURPLE_BLIST_NODE(buddy));
 
@@ -1924,14 +1920,6 @@ purple_blist_init(void)
 						 purple_marshal_VOID__POINTER, G_TYPE_NONE, 1,
 						 PURPLE_TYPE_BLIST_NODE);
 
-	purple_signal_register(handle, "buddy-added",
-						 purple_marshal_VOID__POINTER, G_TYPE_NONE, 1,
-						 PURPLE_TYPE_BUDDY);
-
-	purple_signal_register(handle, "buddy-removed",
-						 purple_marshal_VOID__POINTER, G_TYPE_NONE, 1,
-						 PURPLE_TYPE_BUDDY);
-
 	purple_signal_register(handle, "buddy-icon-changed",
 						 purple_marshal_VOID__POINTER, G_TYPE_NONE, 1,
 						 PURPLE_TYPE_BUDDY);



More information about the Commits mailing list