/soc/2013/ankitkv/gobjectification: d1d789792503: Address a FIXME.
Ankit Vani
a at nevitus.org
Thu Oct 24 08:51:59 EDT 2013
Changeset: d1d789792503830599a36b794998e81f0d1e8e68
Author: Ankit Vani <a at nevitus.org>
Date: 2013-10-24 16:48 +0530
Branch: soc.2013.gobjectification
URL: https://hg.pidgin.im/soc/2013/ankitkv/gobjectification/rev/d1d789792503
Description:
Address a FIXME.
md4 is not used in the jabber protocol.
diffstat:
libpurple/protocols/jabber/jutil.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diffs (32 lines):
diff --git a/libpurple/protocols/jabber/jutil.c b/libpurple/protocols/jabber/jutil.c
--- a/libpurple/protocols/jabber/jutil.c
+++ b/libpurple/protocols/jabber/jutil.c
@@ -32,9 +32,9 @@
#include "presence.h"
#include "jutil.h"
-#include "ciphers/md4hash.h"
+#include "ciphers/sha1hash.h"
+#include "ciphers/sha256hash.h"
#include "ciphers/md5hash.h"
-#include "ciphers/sha1hash.h"
#ifdef USE_IDN
#include <idna.h>
@@ -742,13 +742,13 @@ jabber_calculate_data_hash(gconstpointer
PurpleHash *hash = NULL;
static gchar digest[129]; /* 512 bits hex + \0 */
- /* FIXME: Check the source of this change and what we need here... */
if (g_str_equal(hash_algo, "sha1"))
hash = purple_sha1_hash_new();
- else if (g_str_equal(hash_algo, "md4"))
- hash = purple_md4_hash_new();
+ else if (g_str_equal(hash_algo, "sha256"))
+ hash = purple_sha256_hash_new();
else if (g_str_equal(hash_algo, "md5"))
hash = purple_md5_hash_new();
+
if (hash == NULL)
{
purple_debug_error("jabber", "Could not find %s cipher\n", hash_algo);
More information about the Commits
mailing list