/soc/2013/ankitkv/gobjectification: 214b4782e5da: Do not free ya...

Ankit Vani a at nevitus.org
Tue Sep 3 19:22:39 EDT 2013


Changeset: 214b4782e5dab9394d1707710b825045a4b345e1
Author:	 Ankit Vani <a at nevitus.org>
Date:	 2013-09-04 04:51 +0530
Branch:	 soc.2013.gobjectification.plugins
URL: https://hg.pidgin.im/soc/2013/ankitkv/gobjectification/rev/214b4782e5da

Description:

Do not free yahoo's protocol options in yahoojp, just set it to NULL

diffstat:

 libpurple/protocols/yahoo/yahoojp.c |  10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)

diffs (20 lines):

diff --git a/libpurple/protocols/yahoo/yahoojp.c b/libpurple/protocols/yahoo/yahoojp.c
--- a/libpurple/protocols/yahoo/yahoojp.c
+++ b/libpurple/protocols/yahoo/yahoojp.c
@@ -94,14 +94,8 @@ yahoojp_protocol_base_init(YahooJPProtoc
 	proto_class->id        = "yahoojp";
 	proto_class->name      = "Yahoo JAPAN";
 
-	/* delete yahoo's protocol options */
-	while (proto_class->protocol_options) {
-		PurpleAccountOption *option = proto_class->protocol_options->data;
-		purple_account_option_destroy(option);
-		proto_class->protocol_options =
-				g_list_delete_link(proto_class->protocol_options,
-				proto_class->protocol_options);
-	}
+	/* do not use yahoo's protocol options, we will define our own */
+	proto_class->protocol_options = NULL;
 
 	option = purple_account_option_int_new(_("Pager port"), "port", YAHOO_PAGER_PORT);
 	proto_class->protocol_options = g_list_append(proto_class->protocol_options, option);



More information about the Commits mailing list