/soc/2013/ashmew2/filetransferX: c456aca65aa4: Crash for ~40MB f...

Ashish Gupta ashmew2 at gmail.com
Sun Sep 8 06:41:37 EDT 2013


Changeset: c456aca65aa4ac4696b3b468d336f78cc261a0aa
Author:	 Ashish Gupta <ashmew2 at gmail.com>
Date:	 2013-09-08 14:38 +0530
Branch:	 filetransferX
URL: https://hg.pidgin.im/soc/2013/ashmew2/filetransferX/rev/c456aca65aa4

Description:

Crash for ~40MB files

diffstat:

 libpurple/protocols/jabber/google/google_session.c |  8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diffs (32 lines):

diff --git a/libpurple/protocols/jabber/google/google_session.c b/libpurple/protocols/jabber/google/google_session.c
--- a/libpurple/protocols/jabber/google/google_session.c
+++ b/libpurple/protocols/jabber/google/google_session.c
@@ -1837,7 +1837,11 @@ cb_nice_recv(NiceAgent *agent, guint str
 		share_session->channel_state = GTALK_XFER_CHANNEL_HTTP_SENDING;
 		purple_debug_info("google_session", "\nChanged to _SENDING, Bytes remaining: %llu",
 				  purple_xfer_get_bytes_remaining(xfer));
-		fread_ret = fread(file_buf, 1, 65530, file_ptr);
+		purple_debug_info("google_session", "Calling component_writable..\n");
+		cb_nice_component_writable(share_session->share_agent, share_session->stream_id,
+					   1, share_session);
+
+/*		fread_ret = fread(file_buf, 1, 65530, file_ptr);
 		
 		send_ret = nice_agent_send(share_session->share_agent, share_session->stream_id, 1,
 					   fread_ret, file_buf);
@@ -2181,6 +2185,7 @@ void cb_nice_component_writable(NiceAgen
 
 		  purple_debug_info("google_session", "Inside writable(), SENDING_STATE!\n");
 		  fseek(file_ptr, purple_xfer_get_bytes_sent(xfer),SEEK_SET);
+		  purple_debug_info("google_session", "fseek completed..\n");
 		  purple_debug_info("google_session", "ftell gives : %ld\n", ftell(file_ptr));
 		
 		  if(purple_xfer_get_bytes_remaining(xfer) == 0) {
@@ -2215,6 +2220,7 @@ void cb_nice_component_writable(NiceAgen
 		  
 //TODO??		if (purple_xfer_get_bytes_remaining(xfer) == 0)
 //			exit(0);
+		  purple_debug_info("google_session", "Touching while TRUE's floor..\n");
 		}
                 //TODO: Remove redundant part
 		/*if(share_session->file_to_send)



More information about the Commits mailing list