/pidgin/main: 65f0068c01f7: Remove null check in aim_chat_readro...

Elliott Sales de Andrade qulogic at pidgin.im
Thu Feb 13 20:22:26 EST 2014


Changeset: 65f0068c01f7ee37759b7183f0041c2c359d1c2c
Author:	 Elliott Sales de Andrade <qulogic at pidgin.im>
Date:	 2014-02-12 21:48 -0500
Branch:	 default
URL: https://hg.pidgin.im/pidgin/main/rev/65f0068c01f7

Description:

Remove null check in aim_chat_readroominfo.

Both callers either assume bs is non-NULL, or create it immediately
before hand. I think this check is causing clang to think there's a
possible uninitialized value.

diffstat:

 libpurple/protocols/oscar/family_chat.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff --git a/libpurple/protocols/oscar/family_chat.c b/libpurple/protocols/oscar/family_chat.c
--- a/libpurple/protocols/oscar/family_chat.c
+++ b/libpurple/protocols/oscar/family_chat.c
@@ -50,7 +50,7 @@ flap_connection_destroy_chat(OscarData *
 int
 aim_chat_readroominfo(ByteStream *bs, struct aim_chat_roominfo *outinfo)
 {
-	if (!bs || !outinfo)
+	if (!outinfo)
 		return 0;
 
 	outinfo->exchange = byte_stream_get16(bs);



More information about the Commits mailing list