/pidgin/main: 0394d984580f: Fix tiny memleak when custom browser...

Mark Doliner mark at kingant.net
Tue Jan 28 10:38:11 EST 2014


Changeset: 0394d984580fa3a6fe5caa0f3cdffeeb448b25d6
Author:	 Mark Doliner <mark at kingant.net>
Date:	 2014-01-12 18:17 -0800
Branch:	 release-2.x.y
URL: https://hg.pidgin.im/pidgin/main/rev/0394d984580f

Description:

Fix tiny memleak when custom browser command doesn't work.
This is new code since 2.10.7, so this leak doesn't exist in
the wild.

diffstat:

 pidgin/gtknotify.c |  2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diffs (19 lines):

diff --git a/pidgin/gtknotify.c b/pidgin/gtknotify.c
--- a/pidgin/gtknotify.c
+++ b/pidgin/gtknotify.c
@@ -1433,6 +1433,7 @@ pidgin_notify_uri(const char *uri)
 			purple_notify_error(NULL, NULL, _("Unable to open URL"),
 				_("The 'Manual' browser command has been "
 				"chosen, but no command has been set."));
+			g_free(uri_escaped);
 			return NULL;
 		}
 
@@ -1443,6 +1444,7 @@ pidgin_notify_uri(const char *uri)
 				"the 'Manual' browser command seems invalid."),
 				error ? error->message : NULL);
 			g_error_free(error);
+			g_free(uri_escaped);
 			return NULL;
 		}
 



More information about the Commits mailing list