/pidgin/main: 638471098869: Small bug fix to the wording of add ...

Mark Doliner mark at kingant.net
Wed Jun 18 00:51:45 EDT 2014

Changeset: 638471098869f1f3a8c606d57fc76ce94d62ac86
Author:	 Mark Doliner <mark at kingant.net>
Date:	 2014-06-17 21:51 -0700
Branch:	 default
URL: https://hg.pidgin.im/pidgin/main/rev/638471098869


Small bug fix to the wording of add buddy requests.

The text looks like this:
whoever at example.com (John Doe) wants to add you (yourname at example.com) to his or her buddy list: I'm your biggest fan--please let me add you!

The message at the end is optional and we attempt to intelligently show a
colon or a period based on whether the message exists. However, our logic was
wrong and we were keying off the alias field rather than the message field.

Seems like this bug has probably been around for a while, which surprised me.
And I haven't committed anything in a while, so I'm feeling unsure of myself.


 pidgin/gtkaccount.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff --git a/pidgin/gtkaccount.c b/pidgin/gtkaccount.c
--- a/pidgin/gtkaccount.c
+++ b/pidgin/gtkaccount.c
@@ -2888,7 +2888,7 @@ pidgin_accounts_request_authorization(Pu
 				(have_valid_alias ? ")"   : ""),
-				(have_valid_alias ? ": " : "."),
+				(*escaped_message ? ": " : "."),

More information about the Commits mailing list