/pidgin/main: 546b26744669: Backed out 3a61567. See my comments...

Gary Kramlich grim at reaperworld.com
Sat Mar 22 01:33:12 EDT 2014


Changeset: 546b2674466951119f4fa57bdeadc61cf9ccef5f
Author:	 Gary Kramlich <grim at reaperworld.com>
Date:	 2014-03-22 00:29 -0500
Branch:	 default
URL: https://hg.pidgin.im/pidgin/main/rev/546b26744669

Description:

Backed out 3a61567.  See my comments on https://bitbucket.org/pidgin/main/commits/3a6156743d752b150ac473edff6e5b481db951b3

diffstat:

 pidgin/gtkwebview.c |  40 ----------------------------------------
 1 files changed, 0 insertions(+), 40 deletions(-)

diffs (57 lines):

diff --git a/pidgin/gtkwebview.c b/pidgin/gtkwebview.c
--- a/pidgin/gtkwebview.c
+++ b/pidgin/gtkwebview.c
@@ -1494,37 +1494,6 @@ pidgin_webview_finalize(GObject *webview
 	G_OBJECT_CLASS(parent_class)->finalize(G_OBJECT(webview));
 }
 
-enum {
-	PROP_0,
-	PROP_EXPAND
-};
-
-static void
-pidgin_webview_set_property(GObject *object, guint prop_id, const GValue *value,
-	GParamSpec *pspec)
-{
-	g_return_if_fail(PIDGIN_IS_WEBVIEW(object));
-
-	switch (prop_id) {
-		case PROP_EXPAND:
-			purple_debug_misc("webview",
-				"Ignored expand property (set to %d)",
-				g_value_get_boolean(value));
-			break;
-		default:
-			G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id,
-				pspec);
-	}
-}
-
-static void
-pidgin_webview_get_property(GObject *object, guint prop_id, GValue *value, GParamSpec *pspec)
-{
-	g_return_if_fail(PIDGIN_IS_WEBVIEW(object));
-
-	G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
-}
-
 static void
 pidgin_webview_class_init(PidginWebViewClass *klass, gpointer userdata)
 {
@@ -1610,15 +1579,6 @@ pidgin_webview_class_init(PidginWebViewC
 	gtk_binding_entry_add_signal(binding_set, GDK_KEY_r, GDK_CONTROL_MASK,
 	                             "format-cleared", 0);
 
-	/* properties */
-
-	G_OBJECT_CLASS(klass)->set_property = pidgin_webview_set_property;
-	G_OBJECT_CLASS(klass)->get_property = pidgin_webview_get_property;
-	g_object_class_install_property(G_OBJECT_CLASS(klass),
-		PROP_EXPAND, g_param_spec_boolean("expand",
-			"not used", "It's just a fix, don't use it.", FALSE,
-			G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
-
 	purple_prefs_add_none(PIDGIN_PREFS_ROOT "/webview");
 	purple_prefs_add_bool(PIDGIN_PREFS_ROOT "/webview/inspector_enabled", FALSE);
 }



More information about the Commits mailing list