/pidgin/main: 77d70db4a1d1: Better comment for #8477
Tomasz Wasilczyk
twasilczyk at pidgin.im
Tue May 6 18:50:58 EDT 2014
Changeset: 77d70db4a1d1aebf5cb22a2045bdc540a8849dbe
Author: Tomasz Wasilczyk <twasilczyk at pidgin.im>
Date: 2014-05-07 00:50 +0200
Branch: release-2.x.y
URL: https://hg.pidgin.im/pidgin/main/rev/77d70db4a1d1
Description:
Better comment for #8477
diffstat:
libpurple/protocols/jabber/si.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diffs (13 lines):
diff --git a/libpurple/protocols/jabber/si.c b/libpurple/protocols/jabber/si.c
--- a/libpurple/protocols/jabber/si.c
+++ b/libpurple/protocols/jabber/si.c
@@ -1717,6 +1717,9 @@ void jabber_si_parse(JabberStream *js, c
filesize_64 = g_ascii_strtoull(filesize_c, NULL, 10);
/* TODO 3.0.0: When the core uses a guint64, this is redundant.
* See #8477.
+ *
+ * It may not be necessary on 64-bit machine.
+ * coverity[result_independent_of_operands]
*/
if (filesize_64 > G_MAXSIZE) {
/* Should this pop up a warning? */
More information about the Commits
mailing list