/pidgin/main: b621a018a338: Coverity bug is now a false positive

Tomasz Wasilczyk twasilczyk at pidgin.im
Thu May 15 15:08:19 EDT 2014


Changeset: b621a018a338c30e31df7a596b5a355359648adb
Author:	 Tomasz Wasilczyk <twasilczyk at pidgin.im>
Date:	 2014-05-15 21:08 +0200
Branch:	 release-2.x.y
URL: https://hg.pidgin.im/pidgin/main/rev/b621a018a338

Description:

Coverity bug is now a false positive

diffstat:

 libpurple/proxy.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff --git a/libpurple/proxy.c b/libpurple/proxy.c
--- a/libpurple/proxy.c
+++ b/libpurple/proxy.c
@@ -1720,7 +1720,7 @@ s5_parse_chap_msg(PurpleProxyConnectData
 	navas = *cmdbuf;
 
 	purple_debug_misc("socks5 proxy", "Expecting %d attribute(s).\n", navas);
-	if (G_UNLIKELY(navas > 10000)) { /* XXX: what's the threshold? */
+	if (G_UNLIKELY(navas < 0 || navas > 10000)) { /* XXX: what's the threshold? */
 		purple_proxy_connect_data_disconnect(connect_data,
 			_("Received invalid data on connection with server"));
 		return -1;



More information about the Commits mailing list