/pidgin/main: a3fe30a2666b: Fix signed/unsigned comparison warning.

Elliott Sales de Andrade qulogic at pidgin.im
Thu Nov 13 01:15:39 EST 2014


Changeset: a3fe30a2666bafc19d24876e5f7098a4110b5c71
Author:	 Elliott Sales de Andrade <qulogic at pidgin.im>
Date:	 2014-11-12 19:15 -0500
Branch:	 release-2.x.y
URL: https://hg.pidgin.im/pidgin/main/rev/a3fe30a2666b

Description:

Fix signed/unsigned comparison warning.

The test still works correctly without the fix, but this is quieter.

diffstat:

 libpurple/protocols/mxit/markup.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff --git a/libpurple/protocols/mxit/markup.c b/libpurple/protocols/mxit/markup.c
--- a/libpurple/protocols/mxit/markup.c
+++ b/libpurple/protocols/mxit/markup.c
@@ -592,7 +592,7 @@ static void emoticon_returned( PurpleUti
 	purple_debug_info( MXIT_PLUGIN_ID, "read the length '%i'\n", em_size );
 #endif
 
-	if ( len - pos < em_size ) {
+	if ( len - pos < (gsize)em_size ) {
 		/* not enough bytes left in data! */
 		purple_debug_error( MXIT_PLUGIN_ID, "Invalid emoticon received from wapsite (data length too long)\n");
 		g_free( em_id );



More information about the Commits mailing list