/pidgin/main: 89c89c449595: Use a larger buffer size for untarre...

Mark Doliner mark at kingant.net
Wed Oct 22 10:20:23 EDT 2014

Changeset: 89c89c449595decb327b753ab8b239c7bdeffb29
Author:	 Mark Doliner <mark at kingant.net>
Date:	 2014-03-01 16:35 -0800
Branch:	 release-2.x.y
URL: https://hg.pidgin.im/pidgin/main/rev/89c89c449595


Use a larger buffer size for untarred filenames.

Only used for untarring smiley themes on Windows.
I suspect this won't affect anything. 256 just seems very
small. 4096 seems less likely to lead to truncated filenames
and I'm not worried about trying to open a filename that's
too long for the OS--I think this code handles that sanely.


 pidgin/win32/untar.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff --git a/pidgin/win32/untar.c b/pidgin/win32/untar.c
--- a/pidgin/win32/untar.c
+++ b/pidgin/win32/untar.c
@@ -323,7 +323,7 @@ static long checksum(tblk, sunny)
 /* list files in an archive, and optionally extract them as well */
 static int untar_block(Uchar_t *blk) {
-	static char	nbuf[256];/* storage space for prefix+name, combined */
+	static char	nbuf[4096];/* storage space for prefix+name, combined */
 	static char	*name,*n2;/* prefix and name, combined */
 	static int	first = 1;/* Boolean: first block of archive? */
 	long		sum;	  /* checksum for this block */

More information about the Commits mailing list