/pidgin/main: bfacdb2fbfdc: Prevent a segfault caused by opening...

Michael McConville mmcconville at mykolab.com
Sat Aug 15 19:10:00 EDT 2015


Changeset: bfacdb2fbfdc36154d08ba6c6dfc38c1a268f516
Author:	 Michael McConville <mmcconville at mykolab.com>
Date:	 2015-08-14 17:44 -0400
Branch:	 default
URL: https://hg.pidgin.im/pidgin/main/rev/bfacdb2fbfdc

Description:

Prevent a segfault caused by opening the ExtPlacement plugin's config window.
This isn't a fix for the plugin, of course - I'm planning on looking into that
soon. I've emailed Ankit (the plugin's author) asking about it too.

diffstat:

 pidgin/gtkplugin.c |  2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diffs (12 lines):

diff --git a/pidgin/gtkplugin.c b/pidgin/gtkplugin.c
--- a/pidgin/gtkplugin.c
+++ b/pidgin/gtkplugin.c
@@ -752,6 +752,8 @@ static void plugin_dialog_response_cb(Gt
 	GtkTreeIter iter;
 	GList *list, *it;
 
+	g_return_if_fail(d != NULL);
+
 	switch (response) {
 	case GTK_RESPONSE_CLOSE:
 	case GTK_RESPONSE_DELETE_EVENT:



More information about the Commits mailing list