/soc/2015/jgeboski/facebook: aa4aa525233d: facebook: fixed logic...

James Geboski jgeboski at gmail.com
Sat Jul 18 21:37:45 EDT 2015


Changeset: aa4aa525233de861d08933eb1c8f390823293181
Author:	 James Geboski <jgeboski at gmail.com>
Date:	 2015-07-18 21:37 -0400
Branch:	 facebook
URL: https://hg.pidgin.im/soc/2015/jgeboski/facebook/rev/aa4aa525233d

Description:

facebook: fixed logic error with error detection

diffstat:

 libpurple/protocols/facebook/facebook.c |  3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diffs (13 lines):

diff --git a/libpurple/protocols/facebook/facebook.c b/libpurple/protocols/facebook/facebook.c
--- a/libpurple/protocols/facebook/facebook.c
+++ b/libpurple/protocols/facebook/facebook.c
@@ -180,8 +180,7 @@ fb_cb_api_error(FbApi *api, GError *erro
 
 	/* Non-fatal HTTP errors */
 	nfatal |= (error->domain == FB_HTTP_ERROR) &&
-	          (error->code < 400) &&
-	          (error->code > 500);
+	          ((error->code < 400) || (error->code > 500));
 
 	reason = (nfatal) ? PURPLE_CONNECTION_ERROR_NETWORK_ERROR
 	                  : PURPLE_CONNECTION_ERROR_OTHER_ERROR;



More information about the Commits mailing list