/soc/2015/mmcc/main: d7433629e94d: fix null pointer deref when o...

Michael McConville mmcconville at mykolab.com
Fri Jun 26 13:58:15 EDT 2015


Changeset: d7433629e94d511914df5e3c35a18cf52ac4195b
Author:	 Michael McConville <mmcconville at mykolab.com>
Date:	 2015-06-26 13:58 -0400
Branch:	 default
URL: https://hg.pidgin.im/soc/2015/mmcc/main/rev/d7433629e94d

Description:

fix null pointer deref when opening some plugins' config menus

diffstat:

 pidgin/gtkplugin.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff --git a/pidgin/gtkplugin.c b/pidgin/gtkplugin.c
--- a/pidgin/gtkplugin.c
+++ b/pidgin/gtkplugin.c
@@ -213,7 +213,7 @@ pidgin_plugin_get_config_frame(PurplePlu
 	if (PIDGIN_IS_PLUGIN_INFO(info))
 		priv = PIDGIN_PLUGIN_INFO_GET_PRIVATE(info);
 
-	if (priv)
+	if (priv && priv->config_frame_cb)
 		config = priv->config_frame_cb(plugin);
 
 	if (!config && purple_plugin_info_get_pref_frame_cb(info))



More information about the Commits mailing list