/pidgin/main: d7f124784041: Remove ximagesink and xvimagesink fr...

Mike Ruprecht cmaiku at gmail.com
Sat Jan 23 14:06:34 EST 2016

Changeset: d7f12478404124469720a7d6de6aa330609cd3d7
Author:	 Mike Ruprecht <cmaiku at gmail.com>
Date:	 2016-01-22 03:48 -0600
Branch:	 default
URL: https://hg.pidgin.im/pidgin/main/rev/d7f124784041


Remove ximagesink and xvimagesink from Pidgin options as they're broken

At the time of this commit, ximagesink and xvimagesink are broken
when embedding into a Gtk window. They display as a black screen
or artifacts of not being drawn.

This commit doesn't disallow them completely as the default option
still uses autovideosink, which can choose either of these sinks
still. However, it's probably a good idea to remove known broken
sinks to from the plugin options list.


 pidgin/gtkprefs.c |  6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diffs (16 lines):

diff --git a/pidgin/gtkprefs.c b/pidgin/gtkprefs.c
--- a/pidgin/gtkprefs.c
+++ b/pidgin/gtkprefs.c
@@ -175,8 +175,10 @@ static const gchar *VIDEO_SINK_PLUGINS[]
 	"directdrawsink", "DirectDraw",
 	/* "gconfvideosink", "GConf", */
 	"glimagesink",	"OpenGL",
-	"ximagesink",	"X Window System",
-	"xvimagesink",	"X Window System (Xv)",
+	/* Currently broken when embedding in a Gtk window
+	 * "ximagesink",	"X Window System",
+	 * "xvimagesink",	"X Window System (Xv)",
+	 */

More information about the Commits mailing list