/pidgin/main: 158186c0c751: Stop truncating ICQ passwords to 8 c...

[dx]

Changeset: 158186c0c75180aa64c9b0d645984849e31f33fa
Author:	 dx <dx at dxzone.com.ar>
Date:	 2016-06-16 02:40 -0300
Branch:	 release-2.x.y
URL: https://hg.pidgin.im/pidgin/main/rev/158186c0c751

Description:

Stop truncating ICQ passwords to 8 characters like old ICQ clients did

Fixes #16692

I know we've said that we should fix this "the right way" to ensure that
hypothetical users who rely on password truncation don't get login errors.

But no one is writing that patch, and the real users who want passwords longer
than 8 chars are more important.

If someone actually relies on password truncation, they can easily press
backspace a few times.

diffstat:

 ChangeLog                         |  5 +++++
 libpurple/protocols/oscar/oscar.h |  2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

diffs (27 lines):

diff --git a/ChangeLog b/ChangeLog
--- a/ChangeLog
+++ b/ChangeLog
@@ -13,6 +13,11 @@ version 2.10.13 (MM/DD/YY):
 	Bonjour
 	* Fixed building on Mac OSX (Patrick Cloke) (#16883)
 
+	ICQ:
+	* Stop truncating passwords to 8 characters like old ICQ clients did.
+	(#16692). If you actually needed this, truncate your password
+	manually by pressing backspace a few times.
+
 version 2.10.12 (12/31/15):
 	General:
 	* purple-url-handler now works with Python 3.x (Daniël van Eeden)
diff --git a/libpurple/protocols/oscar/oscar.h b/libpurple/protocols/oscar/oscar.h
--- a/libpurple/protocols/oscar/oscar.h
+++ b/libpurple/protocols/oscar/oscar.h
@@ -110,7 +110,7 @@ extern "C" {
 /**
  * Maximum length for the password of an ICQ account
  */
-#define MAXICQPASSLEN 8
+#define MAXICQPASSLEN 16
 
 #define AIM_MD5_STRING "AOL Instant Messenger (SM)"