/pidgin/main: 98d0c8a7310e: This bring the yahoo unit tests up t...
Gary Kramlich
grim at reaperworld.com
Wed Mar 30 19:25:27 EDT 2016
Changeset: 98d0c8a7310eb6c9f41ede77f31b6301a4c2b200
Author: Gary Kramlich <grim at reaperworld.com>
Date: 2016-03-11 23:56 -0600
Branch: default
URL: https://hg.pidgin.im/pidgin/main/rev/98d0c8a7310e
Description:
This bring the yahoo unit tests up to date. I'm not sure if/why every xmlnode appears to be getting published to dbus, but that's a huge security problem so I've disabled it for now (which fixed the tests)
diffstat:
libpurple/protocols/yahoo/tests/test_yahoo_util.c | 4 ++++
libpurple/xmlnode.c | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diffs (42 lines):
diff --git a/libpurple/protocols/yahoo/tests/test_yahoo_util.c b/libpurple/protocols/yahoo/tests/test_yahoo_util.c
--- a/libpurple/protocols/yahoo/tests/test_yahoo_util.c
+++ b/libpurple/protocols/yahoo/tests/test_yahoo_util.c
@@ -224,6 +224,8 @@ test_html_to_codes(void) {
};
gint i;
+ yahoo_init_colorht();
+
for(i = 0; data[i].input; i++) {
gchar *result = yahoo_html_to_codes(data[i].input);
@@ -231,6 +233,8 @@ test_html_to_codes(void) {
g_free(result);
}
+
+ yahoo_dest_colorht();
}
gint
diff --git a/libpurple/xmlnode.c b/libpurple/xmlnode.c
--- a/libpurple/xmlnode.c
+++ b/libpurple/xmlnode.c
@@ -50,7 +50,7 @@ new_node(const char *name, PurpleXmlNode
node->name = g_strdup(name);
node->type = type;
- PURPLE_DBUS_REGISTER_POINTER(node, PurpleXmlNode);
+// PURPLE_DBUS_REGISTER_POINTER(node, PurpleXmlNode);
return node;
}
@@ -415,7 +415,7 @@ purple_xmlnode_free(PurpleXmlNode *node)
if(node->namespace_map)
g_hash_table_destroy(node->namespace_map);
- PURPLE_DBUS_UNREGISTER_POINTER(node);
+// PURPLE_DBUS_UNREGISTER_POINTER(node);
g_free(node);
}
More information about the Commits
mailing list