/pidgin/main: e0b280f4ab60: Fix a typo that prevented the http c...

Jorge Villase?or salinasv at pidgin.im
Tue May 10 23:01:05 EDT 2016


Changeset: e0b280f4ab60622d31885da13c8b500db4619a26
Author:	 Jorge Villase?or <salinasv at pidgin.im>
Date:	 2016-05-07 16:04 -0700
Branch:	 default
URL: https://hg.pidgin.im/pidgin/main/rev/e0b280f4ab60

Description:

Fix a typo that prevented the http cookies to be set

escaped_value is set to NULL, then checked for NULL to conditionally
set the escaped_value based on the value. This causes us to always send
a NULL value to purple_http_cookie_jar_set_ext which causes the cookie
to not be set.

CID-1358521

diffstat:

 libpurple/http.c |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (21 lines):

diff --git a/libpurple/http.c b/libpurple/http.c
--- a/libpurple/http.c
+++ b/libpurple/http.c
@@ -2011,13 +2011,13 @@ void purple_http_cookie_jar_set(PurpleHt
 {
 	gchar *escaped_name = g_strdup(purple_url_encode(name));
 	gchar *escaped_value = NULL;
-	
-	if (escaped_value) {
+
+	if (value) {
 		escaped_value = g_strdup(purple_url_encode(value));
 	}
-	
+
 	purple_http_cookie_jar_set_ext(cookie_jar, escaped_name, escaped_value, -1);
-	
+
 	g_free(escaped_name);
 	g_free(escaped_value);
 }



More information about the Commits mailing list