[PATCH] reduce code duplication when producing account and protocol option menus

Gabriel Schulhof nix at go-nix.ca
Sun Apr 15 15:12:39 EDT 2007


In the spirit of code duplication reduction, please find attached a
patch that uses a common set of functions to produce both account and
protocol option menus.

It doesn's save /that/ much (just over 40 lines), but it doesn't (seem
to) break anything, and it introduces some useful functions like
GdkPixbuf *get_prpl_pixbuf (PurpleProtocolPluginInfo *info) ;

Also, I'm still trying to figure out how to diff against an upstream mtn
tree, given that I've committed everything to my local tree. So, the
patch takes the old diff -u form. It only touches gtkutils.c.



P.S.: If someone wants to use this patch towards the 100 line code
duplication reduction bounty, feel free to claim it ;o)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: im.pidgin.pidgin.aop_menu.diff
Type: text/x-patch
Size: 16173 bytes
Desc: not available
URL: <http://pidgin.im/pipermail/devel/attachments/20070415/ca08f43b/attachment-0002.bin>

More information about the Devel mailing list