Suggestions

[Zvi Har'El]

I just applied the patch to pidgin-2.1.1, and it works flawlessly, and I
am thankful. BTW, it is easier to apply the concatenation of the three
diff files you have in the zip archive in one shot, so why don't you
distribute it as one patch file? Also, isn't it possible to make this a
plugin, rather than a patch (so it will be more convenient for people
who are not used, like me, to build their tools?)


$*unzip pidgin-2.1.0-protocolmod-diff.zip*

$*cat gtk*.diff > pidgin-2.1.0-protocolmod.patch*

$*patch -p1 -b --verbose < pidgin-2.1.0-protocolmod.patch*

Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- pidgin-2.1.0-vanilla/pidgin/gtkblist.c     2007-08-07
23:45:39.813250000 -0700
|+++ pidgin-2.1.0-protocolmod/pidgin/gtkblist.c 2007-08-08
22:10:48.968750000 -0700
--------------------------
Patching file pidgin/gtkblist.c using Plan A...
Hunk #1 succeeded at 1538.
Hunk #2 succeeded at 2869 (offset 3 lines).
Hunk #3 succeeded at 3154.
Hunk #4 succeeded at 4428 (offset -1 lines).
Hunk #5 succeeded at 4548.
Hunk #6 succeeded at 4615 (offset -1 lines).
Hunk #7 succeeded at 4648.
Hunk #8 succeeded at 5090 (offset -1 lines).
Hunk #9 succeeded at 5255.
Hunk #10 succeeded at 6147 (offset -1 lines).
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- pidgin-2.1.0-vanilla/pidgin/gtkblist.h     2007-08-07
23:45:39.828875000 -0700
|+++ pidgin-2.1.0-protocolmod/pidgin/gtkblist.h 2007-08-08
21:56:08.359375000 -0700
--------------------------
Patching file pidgin/gtkblist.h using Plan A...
Hunk #1 succeeded at 43.
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- pidgin-2.1.0-vanilla/pidgin/gtkconv.c      2007-07-27
22:00:38.000000000 -0700
|+++ pidgin-2.1.0-protocolmod/pidgin/gtkconv.c  2007-08-09
17:08:13.031250000 -0700
--------------------------
Patching file pidgin/gtkconv.c using Plan A...
Hunk #1 succeeded at 84.
Hunk #2 succeeded at 2394 (offset 26 lines).
Hunk #3 succeeded at 4526 with fuzz 1 (offset 19 lines).
Hunk #4 succeeded at 4556 (offset 26 lines).
Hunk #5 succeeded at 6915 (offset 26 lines).
Hunk #6 succeeded at 7270 (offset 33 lines).
done


On 23/08/07 17:17, Josh Williams wrote:

> On 8/23/07, William Ehlhardt <williamehlhardt at gmail.com> wrote:
>   
>> A patch already exists for this behavior. It may be found at the
>> author's website here:
>> http://merwin.bespin.org/pidgin/
>>     
>
> That's awesome! I just got mine patched. Works flawlessly. Thanks!
>
> _______________________________________________
> Devel mailing list
> Devel at pidgin.im
> http://pidgin.im/cgi-bin/mailman/listinfo/devel
>   

-- 
Dr. Zvi Har'El      mailto:rl at math.technion.ac.il    Department of Mathematics
tel:+972-54-4227607                  Technion - Israel Institute of Technology
fax:+972-4-8293388  http://www.math.technion.ac.il/~rl/    Haifa 32000, ISRAEL
"If you can't say somethin' nice, don't say nothin' at all." -- Thumper (1942)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://pidgin.im/pipermail/devel/attachments/20070823/05702aeb/attachment.html>