5ac064e7: Attention API for nudges/buzzes/zaps of …
Sadrul Habib Chowdhury
imadil at gmail.com
Sun Aug 26 17:57:51 EDT 2007
* Jeff Connelly had this to say on [26 Aug 2007, 14:39:47 -0700]:
[snip]
> I added the receiving-im-attention and received-im-attention signals
> in 3ccc848dcffce11aa363f593e383cc1f07d081d0, which have the correct
> arguments. I pass the members of PurpleAttentionType instead of a
> pointer to the structure. Diff available here:
> http://msimprpl.darkthoughts.net/attention4-signals.diff.
>
Instead of having the new signals, would it be enough to use the
existing receiving|received-im-msg signals, and set an appropriate flag
(eg. PURPLE_MESSAGE_ATTENTION) so that a plugin/UI can treat it
differently if it wants to, otherwise just handle it as any other
incoming/outgoing message? I think that would be simpler and
'backward-compatible'. There is a plugin 'ignore' that listens to
'receiving-im-msg' signal, and discards the message when appropriate.
This new signal would require 'ignore' (and any other plugin that deals
with receiving|received- signals) to listen to this additional signal,
which I don't think is really necessary (and I am not sure we can do
without bumping the major). It can be worked-around by emitting both the
-attention and -msg signals from purple, but I think that's unnecessary
complication.
> -Jeff
Sadrul
More information about the Devel
mailing list