Persistent chat rooms
Sadrul Habib Chowdhury
imadil at gmail.com
Tue Aug 28 17:55:06 EDT 2007
* Sean Egan had this to say on [26 Aug 2007, 18:10:36 -0700]:
> On 8/25/07, Sadrul Habib Chowdhury <imadil at gmail.com> wrote:
> > If the changes don't sound too bad (and don't feel too weird when you
> > use the branch -- yes, it compiles and everything!), I plan on merging
> > back with im.pidgin.pidgin.
> Sounds good. Let me know when the merge happens?
I have merged the two branches, apparently. Good thing is, it still
compiles and functions properly.
Perhaps we should also cosider imposing a limit on the history length.
Whether to have this limit in the UI or in the core, I am unsure.
We probably want to use a new icon in the buddy list to indicate that a
conversation is hidden (especially if there's new message in it). Will
the real Hylke Bons please stand up?
> Would it make sense to have "Hide" be the default action when you
> close the window for IMs as well as auto-joined chats? So that it
> always acts like the History plugin, but doesn't require logging?
I do not really care either way. But we probably should emit
'conversation-hiding' signal just before the UI for a conversation is
unset, and 'conversation-displayed' just after the UI is reset. Plugins
may want to do things on either of these events. I think these signals
should be in the UI, and not in the core. This time, will some of
the real crazy patch writers please stand up? ;)
More information about the Devel