Sadrul Habib Chowdhury
imadil at gmail.com
Sat Dec 22 13:51:51 EST 2007
* Evan Schoenberg had this to say on [22 Dec 2007, 10:45:41 -0500]:
> On Dec 21, 2007, at 3:44 PM, Daniel Atallah wrote:
>> Added support for authentication via CRAM-MD5 when using jabber:iq:auth.
>> This, combined with 33785a8c844de496aeeed927bad8b39a6e091931, fixes
>> connectivity with iChat Server 10.5 (a jabberd derivative with SASL
>> support), among other servers, when libpurple is compiled with SASL
>> This looks not quite right to me - the fifth argument to auth_hmac_md5()
>> is a guchar*, but it is being passed a guchar**.
> I agree - that's not right. I find it very strange that it both works as I
> committed it originally (wrong type) and as I've just committed in
> 16e6cd4ffd8a8308380dc016f0afa782a7750374 (Just pass 'digest', not a pointer
> to digest)... Magic? Thanks for the catch... and if there's learning to be
> had as to why both versions worked, I'd love to hear it :)
For 'char digest[...];', all of 'digest', '&digest' and '&digest' are
equivalent. I think that's why both of the versions work.
More information about the Devel