RES: RES: Chat

[Rafael Franco Carvalho]

Hi Sadrul

>It looks like we always try to create a chat with the same name ('MSN
>Chat'), which confuses purple. The fix would be to create a chat with a
>different name each time. Either of the attached patches will work
>around the bug on most occasions, I think. But I am not sure how the
>change in server.c will affect the other prpls, and the change in msn.c
>is very ugly ... I don't like either of the patches. Perhaps you can
>find a cleaner fix? :)
>
>Sadrul

I think we can use chat_id instead of another counter on msn.c. Something
like this:

-----start code-----

gchar *chat_name;

(...)

swboard->chat_id = session->conv_seq++;
chat_name = g_strdup_printf(_("MSN Chat:%d (%s)"), swboard->chat_id);
swboard->conv = serv_got_joined_chat(gc, swboard->chat_id, chat_name);

-----end code-----

There are a "MSN Chat" on switchboard.c at msn_switchboard_add_user(), we
have to do the same thing that msn.c, I guess.
 
I applied you patches, making changes above and it works fine.

Thanks and best regards.

Rafael Franco Carvalho
Technology and Quality on Information

* + 55 34 3291 1700	
* + 55 34 9145-2495	
* rafael.carvalho at tqi.com.br	
* www.tqi.com.br	

-----Mensagem original-----
De: Sadrul Habib Chowdhury [mailto:imadil at gmail.com] 
Enviada em: sexta-feira, 28 de dezembro de 2007 10:21
Para: Rafael Franco Carvalho
Cc: 'Sean Egan'; devel at pidgin.im
Assunto: Re: RES: Chat

* Rafael Franco Carvalho had this to say on [28 Dec 2007, 08:52:05 -0200]:
> 
> Hi Sean,
> 
> >libpurple gives certain meanings to these terms: a 'chat' refers to a
> >multi-user chat, or conference, and an account is an IM account
> >belonging to the local user. By these definitions, you're saying that
> >a Pidgin user can only have his MSN account in one multi-user chat at
> >a time. Is that what you mean?
> 
> Yes, I mean exactly you said above. If you look Evan Schoenberg's e-mail
> you'll see a better explanation of this behavior: "A single multi-user
chat
> entitled 'MSN Chat' ends up getting all messages for all joined multi-user
> chats."
> 

It looks like we always try to create a chat with the same name ('MSN
Chat'), which confuses purple. The fix would be to create a chat with a
different name each time. Either of the attached patches will work
around the bug on most occasions, I think. But I am not sure how the
change in server.c will affect the other prpls, and the change in msn.c
is very ugly ... I don't like either of the patches. Perhaps you can
find a cleaner fix? :)

Sadrul