Revision 8076670c76ed171ce5bc373a596dfd98c5458d91

[Richard Laager]

On Sun, 2007-06-10 at 13:12 -0400, markdoliner at pidgin.im wrote:
> -----------------------------------------------------------------
> Revision: 8076670c76ed171ce5bc373a596dfd98c5458d91
> Ancestor: 05e0540c1a837fa061087b893a855d20e35011ef
> Author: markdoliner at pidgin.im
> Date: 2007-06-10T17:12:00
> Branch: im.pidgin.pidgin
> 
> Modified files:
>         pidgin/gtkft.c
> 
> ChangeLog: 
> 
> Use G_GSIZE_FORMAT when formatting strings containing size_t values in
> the file transfer dialog.  Fixes #1312.

My first concern was that gsize was not size_t, but apparently it is, in
glib 2. That said, G_GSIZE_FORMAT is only in glib 2.6+. Apparently we
could use %zu, but that's non-standard? I think it might be best to keep
the old code for glib < 2.6 and say good enough and then use the fixed
code for new enough glib.

Also, wouldn't we want to remove the "(unsigned long)" cast on those two
function calls?

Richard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://pidgin.im/pipermail/devel/attachments/20070611/4f2c6bbe/attachment.sig>