Revision bca69658a66051202a4311cedd1f218e56f55cb8

[Richard Laager]

On Thu, 2007-06-21 at 06:31 -0400, mshkutkov at soc.pidgin.im wrote:
> -----------------------------------------------------------------
> Revision: bca69658a66051202a4311cedd1f218e56f55cb8
> Ancestor: 219114da14cb249d59df5058edd95acd7b7ada43
> Author: mshkutkov at soc.pidgin.im
> Date: 2007-06-21T08:32:22
> Branch: im.pidgin.soc.2007.remotelogging
> 
> Modified files:
>         libpurple/plugins/log_reader.c
> 
> ChangeLog: 
> 
> Converting all qip logs into UTF8

> +               if (!(utf8_string = g_convert(contents, length, "UTF-8", "Cp1251", NULL, NULL, &error)))
> +                       if (error) {
> +                               purple_debug(PURPLE_DEBUG_ERROR, "QIP logger list",
> +                                       "Couldn't convert file %s to UTF-8\n", filename);
> +                               g_error_free(error);
> +                       }
> +                       
> +               if (utf8_string) {

This could be an else, which would be clearer. Also, fix your missing
braces, so it'll be like this...

...
if (!(utf8_string = ...))
{
	...
}
else
{
...
}
...

Where does this leave the QIP logger? Is it "done" and ready for me to
review for merging into trunk? Have you looked into any of the stuff I
mentioned in my last e-mail about VFS and Google Talk?

Richard