Revision c6c43439075d966d927b8a85f6934e02c0d2bb1e

[Stu Tomlinson]

On Thu, 2007-05-10 at 20:40 -0400, nosnilmot at pidgin.im wrote:
> To get the patch for this revision, please do this:
> mtn log --last 1 --diffs --from c6c43439075d966d927b8a85f6934e02c0d2bb1e

This was:

 disapproval of revision 'cde234fe820467241e86dc0c48917384759d7f4a'

which was:

> Passing --enable-mcheck or --enable-debug will add "-lmcheck", which
> will do the same thing as MALLOC_CHECK_=2 without it having to be
> specified every time.
> 
> I encourage everyone to use at least --enable-debug and
> --enable-fatal-asserts if you can. ;)
> 
> See this page for more information:
> http://www.gnu.org/software/libc/manual/html_node/Heap-Consistency-Checking.html

As it apparently does exactly the same as MALLOC_CHECK_=2 at runtime I
don't see any need for this to be forced upon us. As it happens I've had
a number of occasions where I haven't been able to work on other things
because I'd compiled with --enable-debug which implied --enable-mcheck.

I will run with MALLOC_CHECK_=2 when I can, I also already log all debug
(pidgin -d) log output every time I run Pidgin and enable core dumps.
Adding additional enforced 'debug' features that can't be turned off at
runtime in the hope that more developers will use them is only likely
(in my case) to force me to completely turn them off (the same also
applies to --enable-fatal-asserts which I believe has already been
removed).

Regards,


Stu.