make check: purple_str_to_time broken
stu at nosnilmot.com
Sun Nov 18 08:26:24 EST 2007
make check (and make distcheck) currently fail currently because
purple_str_to_time is broken:
make: Entering directory `/home/stu/build/pidgin-mtn/libpurple/tests'
Running suite(s): Master Suite Cipher Suite Jabber Utility Functions Utility Functions
97%: Checks: 34, Failures: 1, Errors: 0
test_util.c:79:F:Time:test_util_str_to_time: Assertion '377185800 == purple_str_to_time("19811214T12:50:00", TRUE, NULL, NULL, NULL)' failed
1 of 1 tests failed
Please report to devel at pidgin.im
Actually the test is wrong:
$ date -d "19811214T12:50:00" +"%s"
but simply changing the test to that a) doesn't work for some reason,
and b) will break again next time DST kicks in (presumably, I think this
stopped working when DST was reverted a couple of weeks back).
There is a crazy maze of ifdefs lurking in purple_str_to_time that scare
me, is someone more familiar with what is supposed to be happening
here / what is broken?
More information about the Devel