im.pidgin.pidgin: 8bec06d2cd0a64ece46cb3cd73db9b085b91e161

[Jeff Connelly]

On Feb 8, 2008 11:48 PM, Sadrul Habib Chowdhury <imadil at gmail.com> wrote:
> * jeff2 at soc.pidgin.im had this to say on [09 Feb 2008, 02:30:42 -0500]:
> > -----------------------------------------------------------------
> > Revision: 8bec06d2cd0a64ece46cb3cd73db9b085b91e161
>
> [snip]
> > ============================================================
> > --- pidgin/gtkconvwin.h       250c2499fcc142e466d0695dc27e203f56ff9156
> > +++ pidgin/gtkconvwin.h       f2401eb8bac7b34d82b01a8d21dd520e51625c85
> > @@ -51,6 +51,7 @@ struct _PidginWindow
> >               GtkWidget *view_log;
> >
> >               GtkWidget *send_file;
> > +             GtkWidget *send_attention;
> >               GtkWidget *add_pounce;
> >               GtkWidget *get_info;
> >               GtkWidget *invite;
> > ============================================================
>
> I believe this breaks ABI, which means we cannot do this here. I think
> it's necessary to add send_attention at the end of _PidginWindow (not
> just _PidginWindow.menu) to ensure backward compatibility.

I've disapproved 8bec06d2cd0a64ece46cb3cd73db9b085b91e161, since I
couldn't figure out how to do this cleanly (it doesn't seem right to
add the GtkWidget *send_attention outside of the menu struct).
Something to look into for versions where we can break ABI. The patch
will remain at http://developer.pidgin.im/ticket/2788 until then.

-Jeff