[PATCH] Add serv_got_private_alias
John Bailey
rekkanoryo at rekkanoryo.org
Sun Feb 24 16:57:23 EST 2008
On Sun, Feb 24, 2008 at 09:24:47PM +0200, Felipe Contreras wrote:
> > So here is an example patch to use the new serv_got_private_alias.
> > Note that prpl->alias_buddy should also be renamed to
> > set_private_alias or something like that.
> >
> > Best regards.
>
> So?
>
> Any chance of this getting applied?
Funny that you should mention this; I was looking at it just a while
ago. Currently the patch is failing to apply due to conflicts in
oscar.c and server.c because the code has changed too much since 2.3.1.
I was looking at merging it by hand, but I'm not comfortable touching
oscar at all. Any chance I could convince you to resubmit the patch
against current monotone? I have no objections to the patch, for the
record.
Out of curiosity, where would this alias stuff fit if we were to
completely kill off server.c for 3.0.0? Some of it feels like a good
fit for blist.[ch], but it might be confusing if we split some functions
up because they seem like a better fit in, say, prpl.[ch] and their
companion functions are in other files because they seem to fit best
there.
John
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://pidgin.im/pipermail/devel/attachments/20080224/643dcfe5/attachment.sig>
More information about the Devel
mailing list