im.pidgin.pidgin: 7e8103bd3c5298a43a4e18bb59037980f5c213c9

Richard Laager rlaager at wiktel.com
Sat Jan 5 13:13:00 EST 2008


On Wed, 2008-01-02 at 17:57 -0600, Richard Laager wrote:
> On Sun, 2007-12-30 at 22:10 -0500, rekkanoryo at pidgin.im wrote:
> > Felipe Contreras, one of our older Crazy Pacth Writers, noticed that these
> > prototypes were incorrect when he compiled with -Wstrict-prototypes.
> 
> I looked into setting -Wstrict-prototypes and got lots of warnings. From
> a quick text pipeline which I haven't verified, I see 161 in our tree
> and 11 in system headers. These should be relatively easy to clean up.
> I'll take a look at it tomorrow maybe.

I've just pushed some revisions including some to fix this. I've
submitted patches to GTK+, GtkSpell, NSPR, and Meanwhile. Until those
are all accepted and make their way into releases, compiling with
-Wstrict-prototypes is going to produce a lot of warnings from them...
GTK+ seems to produce the most, because it's included from all over the
place (even though it's only a single typedef that needed changing). So,
I've left -Wstrict-prototypes disabled for now.

This fixing exposed a few small typing issues that I cleaned up. I also
stumbled across some things when I was going through the code, so I made
a few other minor cleanups as well.

Richard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://pidgin.im/pipermail/devel/attachments/20080105/3ba17eb3/attachment.sig>


More information about the Devel mailing list